refactor(cypress): correction of cypress tests env variables for Payment method list #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sakilmostak
previously approved these changes
Jul 11, 2024
Sakilmostak
approved these changes
Jul 11, 2024
pixincreate
reviewed
Jul 11, 2024
| @@ -250,7 +244,7 @@ describe("Payment Method list using Constraint Graph flow tests", () => { | |||
|
|
|||
| // payment method list which should only have credit with Stripe and Cybersource | |||
| it("payment-method-list-call-test", () => { | |||
| let data = getConnectorDetails(globalState.get("connectorId"))[ | |||
| let data = getConnectorDetails("stripe")[ | |||
There was a problem hiding this comment.
how do you make sure that it also runs for cybersource? i'm sure that this will run for stripe irrespective of connectors.
the same applies applies else where
There was a problem hiding this comment.
This is only for getting the Response and Request configs which in PaymentMethodList will be same irrespective of any connector, as this is connector agnostic.
Moreover, we have implemented it for Stripe and Cybersource, So if the List runs fine for any 2 connectors it will run for any connectors, again as this is connector agnostic.
pixincreate
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Setting Stripe as Default Pass-by for configs of response in our PaymentMethodList test scenarios.
Additional Changes
Motivation and Context
How did you test it?
Ran Cypress tests on Local:
Checklist
cargo +nightly fmt --allcargo clippy